Backport kernel_process_events custom documentation to 9.3#755
Open
nicholasberlin wants to merge 5 commits into
Open
Backport kernel_process_events custom documentation to 9.3#755nicholasberlin wants to merge 5 commits into
nicholasberlin wants to merge 5 commits into
Conversation
(cherry picked from commit e745043)
Contributor
Author
|
This is a work in progress, please ignore for now. |
* add missing field * add generated file (cherry picked from commit 89c1a22)
…#740) Some rules emit populated threat.technique.subtechnique.{id,name,reference} fields. The Linux and macOS malicious_behavior_alert custom_documentation only listed the parent threat.technique.subtechnique path, causing the EAF custom-documentation validator to fail with undocumented keys. Mirrors the shape already present in the Windows alert (PR #614 era). Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> (cherry picked from commit 332151d)
Contributor
Author
|
Ok, this is ready for review now. |
Member
|
AFAIK everything under
I don't manage the endpoint tests, nor the website page output, so you only need reviews from fellow elastic-endpoint folks for custom docs changes. It's not part of the "release process" of the integration, per se you are good to merge when you get endpoint thumbs 👍 |
pzl
approved these changes
Jul 10, 2026
Endpoint.metrics.documents_volume.{process,security}_events.sources.*
were added to custom_documentation only (#652, #653), so the fields were
never mapped in the package. The metrics index template sets
dynamic: false, so these fields are currently not indexed on any stack.
Define them in custom_schemas/custom_endpoint.yml mirroring the existing
api_events.sources.* mappings, and regenerate with make.
(cherry picked from commit 322d76a)
Requested in review: sample values for the new
documents_volume.{process,security}_events.sources.* mappings so the
automated mapping tests exercise them. Source values reflect what the
endpoint emits: process event sources are opcode names (load_module),
security event sources are diagnostic_<event id> strings.
(cherry picked from commit 52535bc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the custom documentation entry the endpoint-dev EAF suite found missing when endpoint-dev #20923 pinned this repo's
9.3branch as the endpoint-package submodule (build: https://buildkite.com/elastic/endpoint-dev/builds/23076).Cherry-picked from
main:Fixes EAF failures asserting missing custom documentation for:
Generated with Claude Code.
Update: Follow-up build #23081 (after the fix above landed on this branch) flagged 2 more undocumented fields. Added:
2. 89c1a22 - Add missing field in the ASM API events custom documentation (#726)
3. 332151d - Fix Linux and macOS behavior alert custom doc for subtechnique fields (#740)
Fixes additional EAF failures for:
(Build #23081 also had one test_noisy_processes_configuration failure on Windows 11 Arm64 - unrelated, a pre-existing ~4% flake on main too.)
Update 2 (mappings, not just docs): review feedback on the endpoint-dev side pointed out that
Endpoint.metrics.documents_volume.{process,security}_events.sources.*had only ever been added tocustom_documentation- the fields were never defined incustom_schemas, so they are missing from the actual package mappings (the metrics index template isdynamic: false, so they are not indexed). This was true onmainas well; fixed there by #762 and cherry-picked here (regeneration verified on this branch).Note: the sources.* fields are not among the EAF failures this PR originally fixed for 9.3 (endpoint 9.3 documentation for them already existed), but 9.3 endpoint emits them, so the mapping backport applies here too. The other fields in this PR did not need mapping changes:
subtechnique.*andsecurity_descriptorwere already mapped on 9.3 (only documentation lagged), andkernel_process_events.*lives undersystem_impactwhich isenabled: false(intentionally not indexed), matching main.