[New Rule] SMB (Windows File Sharing) Activity from the Internet#6267
Merged
Conversation
Contributor
Rule: New - GuidelinesThese guidelines serve as a reminder set of considerations when proposing a new rule. Documentation and Context
Rule Metadata Checks
New BBR Rules
Testing and Validation
|
|
⛔️ Test failed Results
|
|
⛔️ Test failed Results
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new network new_terms detection rule to alert on inbound SMB (TCP/139,445) from public IPs to RFC1918 destinations, intended to surface Internet scanning/exploitation attempts while suppressing repeat sources.
Changes:
- Introduces a new
new_termsrule for “SMB (Windows File Sharing) Activity from the Internet” with public-source filtering and RFC1918 destination scoping. - Adds an investigation guide (triage, FP guidance, response, setup) and configures
new_termssuppression onsource.ipwith a 5-day history window.
terrancedejesus
approved these changes
Jun 29, 2026
|
Starting the rule tests ... |
|
⛔️ Test failed Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue link(s):
Summary - What I changed
Adds a new
new_termsnetwork detection rule that fires when a public IP reaches an internal host on TCP 139 or 445 (SMB/CIFS). This is the inbound counterpart toinitial_access_smb_windows_file_sharing_activity_to_the_internet.toml; the two rules are mutually exclusive by design. Inbound SMB from the Internet is a direct precondition for EternalBlue (MS17-010) and the broader SMB RCE vulnerability class.new_termssuppression onsource.ipwith a 5-day window collapses repeat Internet scanners to one alert per new external source.Corelight and pfSense are added as primary data sources alongside the existing
network_traffic,panw, andzeekintegrations.Note
pfSense and Corelight support need to be merged first before this rule can be added.
How To Test
Unit Tests, shared stack data, and RTA.
Checklist
bug,enhancement,schema,maintenance,Rule: New,Rule: Deprecation,Rule: Tuning,Hunt: New, orHunt: Tuningso guidelines can be generatedmeta:rapid-mergelabel if planning to merge within 24 hoursContributor checklist