new: ConfirmedPrivateTransfer / UnconfirmedPrivateTransfer support in BacnetClient#200
Merged
Merged
Conversation
gralin
force-pushed
the
new/confirmed-private-transfer
branch
2 times, most recently
from
6c51e98 to
651ea0f
Compare
… BacnetClient BacnetClient could encode ConfirmedPrivateTransfer/UnconfirmedPrivateTransfer (ASHRAE 135 clauses 16.2/16.3) but had no way to send or receive them. Add PrivateTransferRequest (+Begin/End), SendUnconfirmedPrivateTransfer, the OnPrivateTransfer event, and PrivateTransferResponse/PrivateTransferErrorResponse, plus the missing decoders (incl. ConfirmedPrivateTransfer-Error). Tests use the Annex F.4.2/F.4.3 golden vectors and the clause 19.4.2 test message.
gralin
force-pushed
the
new/confirmed-private-transfer
branch
from
651ea0f to
4998a31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds send/receive support for the PrivateTransfer services to BacnetClient. The library already had the encoders but no decoders, client methods, or events, so proprietary services could not be invoked or served.
Tested with 14 unit tests using the ASHRAE 135 Annex F.4.2/F.4.3 golden vectors and the clause 19.4.2 max-conveyable-APDU message, plus an in-memory client<->server round-trip. Also validated end-to-end against bacnet-stack 1.5.0 (C) over Docker, both directions.
Closes #154