test: routed 6-byte VMAC address round-trip (#27)#197
Merged
Conversation
BacnetAddress supports net + arbitrary-length adr + RoutedSource/RoutedDestination, and NPDU.Encode/Decode handle any MAC length. Add a regression test round-tripping routed addresses with 1-, 6- and 18-byte MACs through the NPDU, covering the 6-byte VMAC of devices reached through a router.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#27 asked whether 6-byte VMAC/SADR addresses (devices behind a router) are supported. They are in 4.0 —
BacnetAddresshasnet+ arbitrary-lengthadr+RoutedSource/RoutedDestination, andNPDU.Encode/Decoderead/write the address for any MAC length.Verified with a round-trip test: a routed destination address with 1-, 6- and 18-byte MACs, and a 6-byte VMAC source, all survive encode→decode intact (net + MAC bytes).
Closes #27.