fix!: correct BacnetRejectReason typo RECOGNIZED_SERVICE -> UNRECOGNIZED_SERVICE#196
Merged
Conversation
…ZED_SERVICE Reject reason 9 is "unrecognized-service" per ASHRAE 135 (BACnetRejectReason ::= ENUMERATED, value 9) and YABE (REJECT_REASON_UNRECOGNIZED_SERVICE = 9); the port dropped the "UN". The value (9) is unchanged, so it is wire-compatible - only the public enum member name changes. Also drop the two "should be unrecognized" workaround comments at the call sites. BREAKING CHANGE: BacnetRejectReason.RECOGNIZED_SERVICE renamed to UNRECOGNIZED_SERVICE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BacnetRejectReasonvalue 9 was spelledRECOGNIZED_SERVICE— the "UN" was dropped during the port. Verified in spect:BACnetRejectReason ::= ENUMERATED { … unrecognized-service (9) … }The enumeration value (9) is unchanged, so this is wire-compatible; only the public member name is corrected.
Closes #104.