Akash/issues#5
Open
akashrnjn1 wants to merge 5 commits intomainfrom
Open
Conversation
This commit introduces optimized bitmap loading in `AddRecordPreviewScreen.kt` to improve performance and prevent potential memory issues when handling large images.
- **Optimized Bitmap Loading:**
- A new function `loadOptimizedBitmap(filePath: String)` is added.
- This function first decodes image bounds using `BitmapFactory.Options` with `inJustDecodeBounds = true`.
- It checks if the estimated byte size of the image exceeds 100MB or if its dimensions are larger than the maximum canvas size (32768 pixels).
- If the image is too large, `inSampleSize` is calculated using a new `calculateInSampleSize` function, and `inPreferredConfig` is set to `Bitmap.Config.RGB_565` to reduce memory usage.
- The image is then decoded with the calculated sample size and corrected for orientation using the existing `fixImageOrientation` function.
- In the `LazyRow` displaying file previews, `BitmapFactory.decodeFile(file.path)?.let { fixImageOrientation(it, file.path) }` is replaced with a call to the new `loadOptimizedBitmap(file.path)`.
- **Sample Size Calculation:**
- A new private function `calculateInSampleSize(options: BitmapFactory.Options)` is introduced.
- This function calculates an appropriate `inSampleSize` if the image height is greater than 800 or width is greater than 600, iteratively doubling `inSampleSize` until the scaled dimensions are within reasonable limits.
This commit refactors the `loadOptimizedBitmap` function in `AddRecordPreviewScreen.kt` to improve memory efficiency and prevent crashes due to large images.
- **Bitmap Loading Optimization:**
- The `loadOptimizedBitmap` function now checks for valid image dimensions (width and height > 0) before proceeding.
- It uses system display metrics (`Resources.getSystem().displayMetrics`) to determine a requested width and height for downsampling.
- A `maxBytes` threshold (approximately 80 MB) is introduced as a safe limit for the estimated size of the loaded bitmap.
- The `calculateInSampleSize` function has been updated to consider the image dimensions, maximum allowed dimensions (constrained by `maxCanvasSize`), and the `maxBytes` limit to determine an appropriate `inSampleSize`. It iteratively doubles `inSampleSize` until the scaled image fits within the defined constraints.
- The `inPreferredConfig` is set to `Bitmap.Config.RGB_565` to reduce memory usage (2 bytes per pixel).
- The original bitmap is recycled if a new, rotated bitmap is created in `fixImageOrientation` to free up memory.
- **Error Handling:**
- The function now returns `null` if the initial image dimensions are invalid or if `BitmapFactory.decodeFile` fails to decode the bitmap.
This commit refactors the `loadOptimizedBitmap` function in `AddRecordPreviewScreen.kt` to improve memory efficiency and prevent crashes due to large images.
- **Bitmap Loading Optimization:**
- The `loadOptimizedBitmap` function now checks for valid image dimensions (width and height > 0) before proceeding.
- It uses system display metrics (`Resources.getSystem().displayMetrics`) to determine a requested width and height for downsampling.
- A `maxBytes` threshold (approximately 80 MB) is introduced as a safe limit for the estimated size of the loaded bitmap.
- The `calculateInSampleSize` function has been updated to consider the image dimensions, maximum allowed dimensions (constrained by `maxCanvasSize`), and the `maxBytes` limit to determine an appropriate `inSampleSize`. It iteratively doubles `inSampleSize` until the scaled image fits within the defined constraints.
- The `inPreferredConfig` is set to `Bitmap.Config.RGB_565` to reduce memory usage (2 bytes per pixel).
- The original bitmap is recycled if a new, rotated bitmap is created in `fixImageOrientation` to free up memory.
- **Error Handling:**
- The function now returns `null` if the initial image dimensions are invalid or if `BitmapFactory.decodeFile` fails to decode the bitmap.
This commit refactors the `loadOptimizedBitmap` function in `AddRecordPreviewScreen.kt` to improve memory efficiency and prevent crashes due to large images.
- **Bitmap Loading Optimization:**
- The `loadOptimizedBitmap` function now checks for valid image dimensions (width and height > 0) before proceeding.
- It uses system display metrics (`Resources.getSystem().displayMetrics`) to determine a requested width and height for downsampling.
- A `maxBytes` threshold (approximately 80 MB) is introduced as a safe limit for the estimated size of the loaded bitmap.
- The `calculateInSampleSize` function has been updated to consider the image dimensions, maximum allowed dimensions (constrained by `maxCanvasSize`), and the `maxBytes` limit to determine an appropriate `inSampleSize`. It iteratively doubles `inSampleSize` until the scaled image fits within the defined constraints.
- The `inPreferredConfig` is set to `Bitmap.Config.RGB_565` to reduce memory usage (2 bytes per pixel).
- The original bitmap is recycled if a new, rotated bitmap is created in `fixImageOrientation` to free up memory.
- **Error Handling:**
- The function now returns `null` if the initial image dimensions are invalid or if `BitmapFactory.decodeFile` fails to decode the bitmap.
This commit modifies the `AddRecordPreviewScreen.kt` file to change the maximum canvas size used for image processing. - The `maxCanvasSize` constant has been reduced from `32768` to `8192`. This change likely aims to optimize memory usage or address potential issues with handling very large images on certain devices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.