Optimize CLI log copy buffer#1003
Draft
newmattock wants to merge 1 commit into
Draft
Conversation
This comment was marked as low quality.
This comment was marked as low quality.
|
Per our AI policy we require all communication to be exclusively human written. Until this requirement is met, we can't spare the effort to review this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CliLogsBoxso large daemon/swap log strings are only rebuilt when the filtered log list changes.Why
This targets the UI performance bounty in #727. The log viewer can hold large daemon/session logs; previously every render, including each search input state update, rebuilt the full
logsToRawString(...)copy value. Keeping that derivation memoized avoids redundant string work while preserving the existing filtered-copy behavior.Testing
corepack yarn eslint src/renderer/components/other/RenderedCliLog.tsx --quietPATH="$HOME/.cargo/bin:$PATH" corepack yarn gen-bindingscorepack yarn tscIf this is accepted for the bounty, I can provide the payout address requested by the maintainer.
Fixes part of #727