Skip to content

Optimize CLI log copy buffer#1003

Draft
newmattock wants to merge 1 commit into
eigenwallet:masterfrom
newmattock:optimize-cli-log-copy-buffer
Draft

Optimize CLI log copy buffer#1003
newmattock wants to merge 1 commit into
eigenwallet:masterfrom
newmattock:optimize-cli-log-copy-buffer

Conversation

@newmattock
Copy link
Copy Markdown

Summary

  • Memoize the raw copy payload in CliLogsBox so large daemon/swap log strings are only rebuilt when the filtered log list changes.
  • Normalize the search query once per filter pass instead of once per log row.

Why

This targets the UI performance bounty in #727. The log viewer can hold large daemon/session logs; previously every render, including each search input state update, rebuilt the full logsToRawString(...) copy value. Keeping that derivation memoized avoids redundant string work while preserving the existing filtered-copy behavior.

Testing

  • corepack yarn eslint src/renderer/components/other/RenderedCliLog.tsx --quiet
  • PATH="$HOME/.cargo/bin:$PATH" corepack yarn gen-bindings
  • corepack yarn tsc

If this is accepted for the bounty, I can provide the payout address requested by the maintainer.

Fixes part of #727

@newmattock

This comment was marked as low quality.

@Einliterflasche
Copy link
Copy Markdown

Per our AI policy we require all communication to be exclusively human written. Until this requirement is met, we can't spare the effort to review this.

@Einliterflasche Einliterflasche marked this pull request as draft May 12, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants