chore: rename Langfuse env vars to QUALOPS_LANGFUSE_ prefix#301
Merged
Conversation
Use QUALOPS_LANGFUSE_SECRET_KEY/QUALOPS_LANGFUSE_PUBLIC_KEY/QUALOPS_LANGFUSE_BASE_URL instead of the plain LANGFUSE_* names, passed explicitly into the LangfuseSpanProcessor/LangfuseClient constructors rather than relying on the SDK's own env auto-read. This lets an organization set these vars once for every repo running qualops without colliding with a repo's own unprefixed LANGFUSE_* vars used for unrelated Langfuse projects.
QualOps Code Quality AnalysisStatus: ✅ PASSED - No issues found Summary
No issues found in the analyzed code. 📊 Full ReportPowered by QualOps |
… is empty GitHub Actions sets an unreferenced vars.* to an empty string rather than omitting it, so an org without QUALOPS_LANGFUSE_BASE_URL configured was passing baseUrl: '' into LangfuseSpanProcessor. The SDK treats an explicit empty string as provided rather than falling back to its own default, producing a relative export URL and a hard failure at startup. Treat an empty QUALOPS_LANGFUSE_BASE_URL the same as unset.
sebastianwessel
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use QUALOPS_LANGFUSE_SECRET_KEY/QUALOPS_LANGFUSE_PUBLIC_KEY/QUALOPS_LANGFUSE_BASE_URL instead of the plain LANGFUSE_* names, passed explicitly into the LangfuseSpanProcessor/LangfuseClient constructors rather than relying on the SDK's own env auto-read. This lets an organization set these vars once for every repo running qualops without colliding with a repo's own unprefixed LANGFUSE_* vars used for unrelated Langfuse projects.