Make WebGPU browser tests portable across desktop platforms#7
Merged
Merged
Conversation
47bc4fb to
223e389
Compare
Author
|
I rebuilt this PR branch onto Current PR head:
I also revalidated downstream from Effekseer with nested
Passed in Chrome/WebGPU: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the WebGPU browser-test portability fix to the currently maintained Effekseer LLGI fork. The same branch was originally opened against altseed/LLGI, but that PR was closed because that repository is not being updated.
Changes:
--use-angle=d3d11outside WindowsCHROME_PATHusage for the WebGPU browser testVerification completed locally:
LLGI_Testtarget buildsLLGI_TEST_PASS completed100% tests passed, 0 tests failed out of 1THREE.PerspectiveCamera; its matrices are passed into Effekseer WebGPU rendering; the effect output is validated by changed pixels and ends withEFFEKSEER_TEST_PASS completedRelated bounty/context issue: effekseer/EffekseerForWebGL#113