Skip to content

Feature/upgrade packages#28

Merged
edwinm merged 4 commits into
masterfrom
feature/upgrade-packages
Apr 4, 2026
Merged

Feature/upgrade packages#28
edwinm merged 4 commits into
masterfrom
feature/upgrade-packages

Conversation

@edwinm

@edwinm edwinm commented Apr 4, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Chores
    • Version bump to 0.2.0
    • Updated development tooling and dependencies to modern versions
    • Migrated test infrastructure to use Playwright
    • Modernized ESLint configuration system
    • Upgraded Node.js runtime support to version 22
    • Enhanced TypeScript compiler targets and module resolution settings

@coderabbitai

coderabbitai Bot commented Apr 4, 2026

Copy link
Copy Markdown

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

The project's testing infrastructure transitions from Karma/Mocha to Playwright, ESLint configuration migrates to the flat config format, Node.js runtime upgrades to version 22, and development dependencies are modernized. Legacy configuration files are removed and new Playwright-specific configurations are added.

Changes

Cohort / File(s) Summary
Test Framework Migration
karma.conf.cjs, test/cuprum.spec.ts
Removed Karma configuration and migrated test suite from Mocha callbacks to Playwright's test runner with async/await patterns.
ESLint Configuration Modernization
.eslintignore, .eslintrc.cjs, eslint.config.js
Removed legacy ESLint configuration files and added new flat config (eslint.config.js) with TypeScript support and Prettier integration.
CI/CD and Build Tooling
.github/workflows/test.yml, .husky/pre-commit, package.json
Updated GitHub Actions to Node.js 22 with Playwright browser setup, simplified pre-commit hook, and changed test command from Karma to Playwright; removed Coveralls integration.
Dependency and Configuration Updates
package.json, tsconfig.json
Version bumped to 0.2.0; ESLint ecosystem restructured (moved to @eslint/js and typescript-eslint); Playwright added; Karma/Mocha removed; TypeScript and Rollup dependencies upgraded; compiler targets modernized to ES2023/ES2015.
Type Refinement
src/cuprum.ts
Updated interval() timer variable type from NodeJS.Timeout cast to ReturnType<typeof setInterval> for improved type alignment.
Test Configuration
playwright.config.ts
Added new Playwright configuration specifying test directory and file matching pattern (.spec.ts).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 From Karma's chains we hop away,
Playwright's paths light up the day!
ESLint configs lean and clean,
TypeScript's future bright and keen—
This rabbit cheers the upgrade spree! 🎉

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'Feature/upgrade packages' is vague and generic, using non-descriptive terms that don't clearly convey the specific nature of the package upgrades or the main architectural changes involved. Use a more specific title that describes the primary change, such as 'Migrate from Karma/Mocha to Playwright and upgrade ESLint to flat config' or 'Upgrade testing framework to Playwright and modernize ESLint configuration'.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/upgrade-packages

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

sonarqubecloud Bot commented Apr 4, 2026

Copy link
Copy Markdown

@edwinm edwinm merged commit 002f1ae into master Apr 4, 2026
6 of 7 checks passed
@edwinm edwinm deleted the feature/upgrade-packages branch April 4, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant