Meta mail notifications 2703851#1
Open
edurenye wants to merge 3 commits into
Open
Conversation
edurenye
force-pushed
the
meta_mail_notifications-2703851
branch
2 times, most recently
from
b554a21 to
dfb7876
Compare
| /** @var \Drupal\tmgmt\JobItemInterface $original */ | ||
| $original = $job_item->original; | ||
| if ($job_item->isNeedsReview() && !$original->isNeedsReview()) { | ||
| \Drupal::service('tmgmt_courier.notification')->sendNotification('job_item_needs_review', ['tmgmt_job_item' => $job_item, 'tmgmt_job' => $job_item->getJob()]); |
There was a problem hiding this comment.
Each notification needs to be sent to a default recipient. Here it's the job creator.
A template can optionally override the recipient.
There was a problem hiding this comment.
Ah the default recipient should be identified by the Account object, not an email. Then courier can negotiate based on account and consider user preferences including switching to an SMS instead of a mail.
edurenye
force-pushed
the
meta_mail_notifications-2703851
branch
from
48ac6f4 to
0936fb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.