registration-toolkit 1.8.0 (new formula)#12
Closed
csparker247 wants to merge 8 commits into
Closed
Conversation
C++ utilities for image-to-image and image-to-mesh registration. v1.8.0 is the first proper GitHub release after the GitLab → GitHub migration; the v1.7.0 tarball was unstable due to mirror re-pushes. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Upstream's CMake pulls smgl, bvh, libcore, and OpenABF via FetchContent. Each is pinned to an immutable commit/tag, so bottle reproducibility is preserved. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
brew audit (FormulaAudit/ComponentsOrder) requires depends_on blocks before allow_network_access!. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Homebrew traps live FetchContent calls (trap_fetchcontent_provider.cmake) regardless of allow_network_access!. Replace that approach with the prescribed Homebrew pattern: declare smgl, bvh, libcore, and OpenABF as resources at the same commits the upstream CMake pins, stage them under _deps/, and direct the build at the pre-staged sources via FETCHCONTENT_SOURCE_DIR_<NAME> with FETCHCONTENT_FULLY_DISCONNECTED. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
GitHub/GitLab autogenerated archive tarballs are not byte-stable enough for sha256 pinning — every fetch can vary in gzip metadata. Switch each resource to a git URL with an explicit `revision:` so the content-addressed commit SHA is the immutable identifier, eliminating the tarball-checksum drift. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- The binary links libtiff (per upstream README); declaring it satisfies `brew linkage --test`. - `rt_register --help` exits 0 and the output uses `--log-level` (not "Usage"); update the test to match what the tool actually prints. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The binary links libfmt (transitively via spdlog, but linkage --test requires direct declaration of anything actually linked). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
rt_register prints its --help output to stderr. shell_output without 2>&1 was capturing an empty stdout, so the assert_match against the empty string failed. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Formula/registration-toolkit.rbat v1.8.0.Source
Notes
GPL-3.0-or-later.test doexercisesrt_register --help, allowing exit code 1 (Boost.ProgramOptions exits non-zero on help).Test plan
brew test-botpasses on ubuntu-latest, macos-14, macos-15.auto-label.ymladdspr-pull(branch name matchesbump-*).publish.ymluploads bottles to ghcr.io and force-pushes the rewritten formula to main.brew install educelab/code/registration-toolkitworks on a clean machine.🤖 Generated with Claude Code