refactor: align identifier naming with codebase convention (#94)#95
Merged
Conversation
Apply the codebase naming convention (codified in conductor/code_styleguides/cpp.md, commit 26fa1fb) to existing camelCase identifiers across the LSCM/HLSCM and ABF surfaces: Group A — detail:: namespace (no public API impact, no shims): - detail::lscm::buildSystem -> BuildSystem - detail::hlscm::buildHierarchy -> BuildHierarchy - detail::hlscm::buildLevelMesh -> BuildLevelMesh - detail::hlscm::prolongateUVs -> ProlongateUVs - detail::hlscm::solveLSCMLevel -> SolveLSCMLevel - DecimationMesh::numAliveVerts -> num_alive_verts - DecimationMesh::numAliveFaces -> num_alive_faces - DecimationMesh::tryCollapse -> try_collapse - DecimationMesh::collapseCost -> collapse_cost - DecimationMesh::isAlive -> is_alive - DecimationMesh::isCollapsible -> is_collapsible - DecimationMesh::vertexNeighbors -> vertex_neighbors - DecimationMesh::rebuildAndGetEdges -> rebuild_and_get_edges - DecimationMesh private methods -> compute_quadrics_, build_edges_ - DecimationMesh private members -> is_boundary_, is_pinned_, face_alive_, vert_faces_, num_alive_verts_, num_alive_faces_, scratch_*_ - CollapseRecord members -> v_removed, v_kept, containing_tri - HierarchyLevel members -> local_to_original, original_to_local Group B — public instance setters (with [[deprecated]] shims slated for removal in 3.0): - ABF/ABFPlusPlus::setMaxIterations -> set_max_iterations - ABF/ABFPlusPlus::setGradientThreshold -> set_gradient_threshold - HierarchicalLSCM::setLevelRatio -> set_level_ratio - HierarchicalLSCM::setMinCoarseVertices -> set_min_coarse_vertices - ABF/ABFPlusPlus::maxIters_ -> max_iters_ - ABF/ABFPlusPlus::gradThreshold_ -> grad_threshold_ - HierarchicalLSCM::levelRatio_ -> level_ratio_ - HierarchicalLSCM::minCoarseVertices_ -> min_coarse_vertices_ - ABLSCM/HLSCM::legacyPinIndices_ -> legacy_pin_indices_ (the latter was a violation I introduced in PR #93) The existing setPinnedVertices deprecated shims (from PR #93) keep their pre-existing camelCase name — they're already slated for 3.0 removal and renaming would double-migrate users. Tests: all 60 parameterization assertions pass (6/6 binaries). Deprecation warnings only fire from the pre-existing PR #93 shim tests; new shims compile clean since test callers were updated. Single-header amalgamation regenerated.
- LSCMSystem.hpp AutoPlacePair signature: re-apply v18-preferred wrap. - Regenerate single_include after the late computeQuadrics_/buildEdges_ rename.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #94.
Summary
Applies the codebase naming convention (codified in
conductor/code_styleguides/cpp.md) to identifiers that pre-existed incamelCaseform:detail::*algorithms → PascalCase (buildSystem→BuildSystem, etc.)detail::hlscm::DecimationMeshinstance methods + private members → lower_snake_caseCollapseRecord/HierarchyLevelPOD members → lower_snake_casesetMaxIterations,setLevelRatio, etc.) → lower_snake_case, with[[deprecated]]shims slated for removal in 3.0maxIters_,levelRatio_, etc.) → snake_case_legacyPinIndices_→legacy_pin_indices_(violation I introduced in PR feat(lscm): multi-pin UV constraints on ABLSCM and HLSCM #93)The existing
setPinnedVerticesshims (from PR #93) keep their camelCase name — they're already slated for 3.0 removal.Backward compatibility
[[deprecated]]shims with the original camelCase name. Downstream callers compile with a deprecation warning, slated for removal in 3.0.detail::*renames have no public ABI contract, no shims.Test plan
clang-format -i(v18-equivalent reflow) clean