Skip to content

🧹 Extract file loading/parsing from evaluateSchedulingFreezePolicy #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
edithatogo wants to merge 1 commit into from
Closed

🧹 Extract file loading/parsing from evaluateSchedulingFreezePolicy #573

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 59 additions & 46 deletions src/policy/scheduling-freeze.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,59 +95,18 @@ export async function evaluateSchedulingFreezePolicy(params: {
return decision;
}

const policyText = await readTextFile(params.freezePolicyPath);
if (policyText === undefined) {
return {
allowed: false,
policyPath: params.freezePolicyPath,
cataloguePath: params.cataloguePath,
reason: `Could not read freeze-policy file: ${params.freezePolicyPath}`,
status: "invalid",
catalogueSummary,
};
}

let parsed: unknown;
try {
parsed = JSON.parse(policyText);
} catch {
return {
allowed: false,
policyPath: params.freezePolicyPath,
cataloguePath: params.cataloguePath,
reason: `Freeze-policy file is not valid JSON: ${params.freezePolicyPath}`,
status: "invalid",
catalogueSummary,
};
}

const parsedPolicy = PolicyEnvelopeSchema.safeParse(parsed);
if (!parsedPolicy.success) {
const firstIssue = parsedPolicy.error.issues[0];
const detail = firstIssue?.message ?? "unknown schema issue";
const loadResult = await loadFreezePolicy(params.freezePolicyPath);
if (!loadResult.success) {
return {
allowed: false,
policyPath: params.freezePolicyPath,
cataloguePath: params.cataloguePath,
reason: `Freeze-policy schema validation failed (${params.freezePolicyPath}): ${detail}`,
status: "invalid",
reason: loadResult.reason,
status: loadResult.status,
catalogueSummary,
};
}

const policy: SchedulingFreezePolicy = {
schemaVersion: parsedPolicy.data.schemaVersion ?? 1,
status: parsedPolicy.data.status,
active: parsedPolicy.data.active,
reason: parsedPolicy.data.reason,
reasonCode: parsedPolicy.data.reasonCode,
freezeUntil: parsedPolicy.data.freezeUntil,
resumeAt: parsedPolicy.data.resumeAt,
until: parsedPolicy.data.until,
note: parsedPolicy.data.note,
source: parsedPolicy.data.source,
raw: parsed,
};
const policy = loadResult.policy;

const active = isPolicyActive(policy, now);
if (!active) {
Expand Down Expand Up @@ -311,3 +270,57 @@ function validateExternalCatalogue(cataloguePath: string | undefined): Promise<
function extractArrayCount(value: unknown): number | undefined {
return Array.isArray(value) ? value.length : undefined;
}

async function loadFreezePolicy(
policyPath: string,
): Promise<
| { success: true; policy: SchedulingFreezePolicy }
| { success: false; reason: string; status: "invalid" }
> {
const policyText = await readTextFile(policyPath);
if (policyText === undefined) {
return {
success: false,
reason: `Could not read freeze-policy file: ${policyPath}`,
status: "invalid",
};
}

let parsed: unknown;
try {
parsed = JSON.parse(policyText);
} catch {
return {
success: false,
reason: `Freeze-policy file is not valid JSON: ${policyPath}`,
status: "invalid",
};
}

const parsedPolicy = PolicyEnvelopeSchema.safeParse(parsed);
if (!parsedPolicy.success) {
const firstIssue = parsedPolicy.error.issues[0];
const detail = firstIssue?.message ?? "unknown schema issue";
return {
success: false,
reason: `Freeze-policy schema validation failed (${policyPath}): ${detail}`,
status: "invalid",
};
}

const policy: SchedulingFreezePolicy = {
schemaVersion: parsedPolicy.data.schemaVersion ?? 1,
status: parsedPolicy.data.status,
active: parsedPolicy.data.active,
reason: parsedPolicy.data.reason,
reasonCode: parsedPolicy.data.reasonCode,
freezeUntil: parsedPolicy.data.freezeUntil,
resumeAt: parsedPolicy.data.resumeAt,
until: parsedPolicy.data.until,
note: parsedPolicy.data.note,
source: parsedPolicy.data.source,
raw: parsed,
};

return { success: true, policy };
}
Loading