🧪 test(predict): add test for predict rust error path - #196
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
🎉 Welcome @edithatogo! Thank you for your first pull request to mars! We're excited to have you as a contributor. Our team will review your PR soon. In the meantime, please ensure all CI checks pass. |
🎯 What: Adds a test case for
pymars.runtime._predict_with_rust()to ensure it properly handlesValueErrorandTypeErrorexceptions during_coerce_rows_for_rustexecution, as expected by the python fallback logic.📊 Coverage: Specifically covers the
except (TypeError, ValueError): return Noneblock insidepymars.runtime._predict_with_rust().✨ Result: Increased code coverage by adding the missing test path and improving validation of the failure-propagation pipeline for rust predictions. Also performed a pre-commit pass fixing some trailing newlines across the repo.
PR created automatically by Jules for task 12315012125836733604 started by @edithatogo