Fix Consumer priority propagation and queue starvation - #157
Open
skshih wants to merge 1 commit into
Open
Conversation
…starvation Propagate the requested priority to the Consumer Executor in Orch::addConsumer(). Set the IntfMgr STATE_PORT and STATE_LAG consumer priorities to 100 and 200 respectively. Drain stale selectable notifications when pops() returns no entries while preserving the 202311.X batch-processing behavior. Add unit tests for Executor priority propagation, inflated queue draining, and priority-based Select dispatch ordering. The BGP neighbor priority change is not backported because 202311.X does not contain the corresponding object-tracking consumer.
skshih
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Orch::addConsumer().STATE_PORTandSTATE_LAGConsumer priorities to100 and 200 respectively.
pops()returns noentries.
draining, and priority-based Select dispatch ordering.
Why I did it
The priority passed to the Consumer table was not propagated to the
outer Consumer Executor. As a result, the Executor retained the
default priority of 0.
In addition, batched key processing could leave the RedisSelect
notification counter artificially inflated. This kept the Consumer in
the ready queue and could starve lower-priority events.
How I verified it
git diff --checkpassed.