The egress ACL table fails to bind to channel ports on the Xsight ES9618XX device. - #136
Merged
Merged
Conversation
…tforms. - Why I did it: Previously, several workarounds were introduced for the Egress ACL table to accommodate limitations on Broadcom chips. These changes included: * Only supporting SAI_ACL_BIND_POINT_TYPE_PORT. * Replacing SAI_ACL_TABLE_ATTR_FIELD_ETHER_TYPE with SAI_ACL_TABLE_ATTR_FIELD_ACL_IP_TYPE. * Removing SAI_ACL_TABLE_ATTR_FIELD_ACL_RANGE_TYPE. However, these modifications were applied globally and are not necessary for non-Broadcom platforms, such as Xsight. - What I did: This commit refactors the implementation to ensure these specific workarounds are conditionally applied only when the underlying hardware is a Broadcom platform. - How I verified it: The test_acl.py automation suite was run to verify the change. Tests passed successfully on both platforms, confirming the correct behavior: * ES9618XX (Xsight) * AS9817-64D (Broadcom)
ezio-chen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
The egress ACL table fails to bind to channel ports on the Xsight ES9618XX device.
What I did
With the addition of support for the Xsight ES9618XX device, some platform-specific behaviors previously applied only to Broadcom need to be adjusted. The following changes were restricted to the Broadcom platform:
How I verified it
Executed test_acl.py to ensure the changes do not introduce side effects. Verified on the following platforms: