Skip to content

Use https url #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danielpietzsch wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Use https url #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8d05a03
Now using the W3C's service HTTPS URL
danielpietzsch Apr 1, 2024
a752af0
Now using the HTTPS URL for .validate_data, too.
danielpietzsch Apr 1, 2024
ba34268
Fixing a typo
danielpietzsch Apr 1, 2024
45f71ec
Fixing Gem name in installation instructions
danielpietzsch Apr 1, 2024
a30d32d
Updating link to API documentation
danielpietzsch Apr 1, 2024
f639e01
Using the more generic docs URL
danielpietzsch Apr 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ This assertion implements a cache to improve the performance of the tests and to
Add this line to your application's Gemfile:

```ruby
gem 'feed_validator'
gem 'feedvalidator'
```

And then execute:
Expand All @@ -24,7 +24,7 @@ And then execute:

Or install it yourself as:

$ gem install feed_validator
$ gem install feedvalidator


## Examples
Expand Down Expand Up @@ -64,7 +64,7 @@ Or install it yourself as:

Documentation can be found at

* http://feedvalidator.rubyforge.org
* https://www.rubydoc.info/gems/feedvalidator/

## License

Expand Down
10 changes: 5 additions & 5 deletions lib/feed_validator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,9 @@ def validate_data(rawdata)
begin
# headers = VERSION == "1.8.4" ? {'Content-Type'=>'application/x-www-form-urlencoded'} : {}
headers = {'Content-Type'=>'application/x-www-form-urlencoded'}
@response = Net::HTTP.start('validator.w3.org',80) {|http|
http.post('/feed/check.cgi',params,headers)
}
@response = Net::HTTP.start('validator.w3.org', 443, use_ssl: true) do |https|
https.post('/feed/check.cgi', params, headers)
end
rescue Exception => e
warn "Exception: #{e.class}: #{e.message}\n\t#{e.backtrace.join("\n\t")}" if $VERBOSE
return false
Expand All @@ -109,7 +109,7 @@ def validate_url(url)
params = "url=#{CGI.escape(url)}&output=soap12"
@request_type = :url
begin
@response = Net::HTTP.get_response('validator.w3.org',"/feed/check.cgi?#{params}",80)
@response = Net::HTTP.get_response(URI("https://validator.w3.org/feed/check.cgi?#{params}"))
rescue Exception => e
warn "Exception: #{e.class}: #{e.message}\n\t#{e.backtrace.join("\n\t")}" if $VERBOSE
return false
Expand All @@ -121,7 +121,7 @@ def validate_url(url)
alias :valid? :valid

def to_s
msg = "Vailidity: #{@valid}\n"
msg = "Validity: #{@valid}\n"
msg << "Errors count: #{@errors.size}\n"
@errors.each_with_index{ |item, i| msg << "(#{i+1}) type: #{item[:type]} | line: #{item[:line]} | column: #{item[:column]} | text: #{item[:text]},\n"}
msg << "Warnings count: #{@warnings.size}\n"
Expand Down