Skip to content

add FreeBSD support#53

Open
fraenki wants to merge 1 commit into
edestecd:masterfrom
markt-de:freebsd_support
Open

add FreeBSD support#53
fraenki wants to merge 1 commit into
edestecd:masterfrom
markt-de:freebsd_support

Conversation

@fraenki

@fraenki fraenki commented Jan 28, 2018

Copy link
Copy Markdown
  • Add support for the FreeBSD operating system
  • Make the "root" group configurable (it's "root" on Linux, "wheel" on FreeBSD)
  • Tested on Puppet 5.x, change metadata.json accordingly

@edestecd

Copy link
Copy Markdown
Owner

Thanks for your PR! I'm excited about adding new OSes. I am going to try and get this merged first, so bear with me: #38

I may need you to rebase after that.

@edestecd

Copy link
Copy Markdown
Owner

Looks like you didn't modify the files that the tests are complaining about. I need to get some things updated so the test pass. I wouldn't worry about it at this point.

@fraenki

fraenki commented Jan 29, 2018

Copy link
Copy Markdown
Author

I may need you to rebase after that.

Sure thing!

I need to get some things updated so the test pass. I wouldn't worry about it at this point.

👍

@fraenki

fraenki commented Sep 16, 2019

Copy link
Copy Markdown
Author

@edestecd Do you still plan to merge this PR?

fraenki pushed a commit to markt-de/puppet-clamav that referenced this pull request Sep 23, 2019
@edestecd

Copy link
Copy Markdown
Owner

This looks good to me. Would you mind rebasing? Sorry for the delay.

@fraenki fraenki force-pushed the freebsd_support branch 2 times, most recently from 47a53b2 to 4ef4268 Compare September 2, 2020 09:36
@fraenki

fraenki commented Sep 2, 2020

Copy link
Copy Markdown
Author

@edestecd Rebased and ready for merge :)

@fraenki

fraenki commented Oct 16, 2020

Copy link
Copy Markdown
Author

@edestecd Rebased (again) and fixed the merge conflict, please merge :)

@fraenki

fraenki commented Jan 25, 2021

Copy link
Copy Markdown
Author

Hi @edestecd, now that version 2.0 is out, would you please consider to merge this PR? Thanks! :)

@fraenki

fraenki commented Aug 17, 2022

Copy link
Copy Markdown
Author

ping @edestecd :)

@fraenki

fraenki commented Aug 23, 2023

Copy link
Copy Markdown
Author

Hi @edestecd, we plan to continue the maintenance of this Puppet module. Would you be interested to transfer it to us or to voxpupuli? If not, we would continue work on our fork instead. Please let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants