Support for multiple initrds#78
Open
arcriley wants to merge 1 commit intoedera-dev:mainfrom
Open
Conversation
concatenated into one buffer. Most tools that build initrds (eg Dracut) do this for you but there are some situations where this can be extremely useful.
Member
|
Will review this weekend! |
Author
I am mostly looking for feedback on the code styling before I put too many hours into the next steps. The purpose of splitting initrd is to use signed hashes. It would be trivial to hide malware in a monolithic initrd. However this was just a low hanging fruit. I am mostly looking for an experienced Rust developer to review this before I put too much additional time into boot selection or other more complex PRs. If you have other repositories that are higher priority please point me at them, I am job hunting and looking to contribute to Rust projects refresh my familiarity. You can use me for free code work until I am locked into another "no compete" deal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for several initrds which are provided to the kernel concatenated into one buffer. Most tools that build initrds (eg Dracut) do this for you but there are some situations where this can be extremely useful.
A single string is still supported this will still work
chainload.linux-initrd = 'path/to/initrd'
but now an array of initrds are also supported which as a good feel with other kernel arrays in sprout.toml;
chainload.linux-initrd = ['path/to/initrd1', 'path/to/initrd2']
chainload.options = ["root=rootfs", "ro", "init=/usr/lib/systemd/systemd"]
This still supports undefined initrd and empty_is_none* functions were removed as now obsolete.