wip: Device Management#21
Open
Sweetsurbhi88 wants to merge 14 commits intomainfrom
Open
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
1. Device State: CLEAN, DIRTY, SCRUB, BUSY 2. DeviceStateUpdate RPC 3. DeviceChanged Event Signed-off-by: Surbhi Kakarya <surbhi@edera.dev>
Signed-off-by: Surbhi Kakarya <surbhi@edera.dev>
Signed-off-by: Surbhi Kakarya <surbhi@edera.dev>
Signed-off-by: Surbhi Kakarya <surbhi@edera.dev>
This help us distinguish between creating and available state where available state will be marked for "Clean Device" especially after scrubbing. Signed-off-by: Surbhi Kakarya <surbhi@edera.dev>
…or Workload fails due to any reason and prevent marking it from Tainted, otherwise it ends in a device reconciler endles loop. Signed-off-by: Surbhi Kakarya <surbhi@edera.dev>
Signed-off-by: Surbhi Kakarya <surbhi@edera.dev>
Signed-off-by: Surbhi Kakarya <surbhi@edera.dev>
Sweetsurbhi88
force-pushed
the
surbhi/device-db
branch
from
4edff4e to
8968c22
Compare
bleggett
reviewed
May 1, 2026
| message DestroyDeviceReply {} | ||
|
|
||
| message ResolveAndValidateDeviceRequest { | ||
| oneof DeviceRequest { |
Collaborator
There was a problem hiding this comment.
Suggested change
| oneof DeviceRequest { | |
| oneof device_request { |
lintfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buf will have a single failure:
Previously present message "DeviceInfo" was deleted from file.
Error: Field "1" with name "id" on message "DeviceReferenceSpec" changed option "json_name" from "name" to "id".
Error: Field "1" on message "DeviceReferenceSpec" changed name from "name" to "id".
Error: Previously present field "1" with name "devices" on message "ListDevicesReply" was deleted.