Finally gsd#125
Open
stephantaljaard24-boop wants to merge 3 commits into
Open
Conversation
The chart-creation effect had empty deps and ran once on mount, but the container div only existed once a ticker was selected — before that, ChartPanel returned an early "select a ticker" branch with no ref target. By the time a ticker was picked, the once-only effect had already bailed on a null ref, so createChart() never fired and the panel stayed permanently blank. Keep the container always mounted and overlay the placeholder message instead of replacing it, so the effect finds a real node on its one pass. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012MnFoUnDVox3oYzxMan4pA
GSD self-update refreshes agents/commands/workflows/templates under .claude/get-shit-done and .claude/agents, archiving prior local customizations into .claude/gsd-local-patches for reference. Also persists the full set of workflow toggles chosen via /gsd:settings (nyquist validation, pattern mapper, UI phase/gate, AI integration phase, code review depth, worktrees, git tagging, context warnings) into .planning/config.json, which previously only recorded research/plan_check/verifier. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012MnFoUnDVox3oYzxMan4pA
Start/stop scripts now detect docker on PATH and fall back to podman if it's absent, so users without Docker Desktop can still run the app. Verified end-to-end against a real Podman machine (build, run, health check, stop all succeeded). Also fixes two pre-existing bugs found while in here: - start_mac.sh used container/image name "finally-gsd" and volume "finally-data-gsd" while stop_mac.sh and the Windows scripts used "finally"/"finally-data" — stop_mac.sh could never find what start_mac.sh started. Standardized on "finally"/"finally-data". - start_mac.sh printed the wrong port (8008) in its success message. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012MnFoUnDVox3oYzxMan4pA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.