Add comprehensive MARKET_DATA_DESIGN.md to planning directory#113
Open
stephantaljaard24-boop wants to merge 1 commit into
Open
Conversation
Full implementation-ready design for the market data backend covering: - Architecture overview (strategy pattern, push model, thread-safe cache) - All 8 module files with complete code snippets - GBM math explanation and correlated moves via Cholesky decomposition - Massive API client with lazy import strategy and error handling policy - SSE streaming with correct AsyncGenerator return type annotation - FastAPI lifecycle integration and dependency injection patterns - Watchlist coordination flows including open-position edge case - Testing strategy with all 6 test modules and mock patterns - Configuration reference table Incorporates all findings from the code review: version counter under lock, get_tickers() as public method, _fetch_snapshots mock strategy for test resilience without massive package installed, correct return type annotation on _generate_events. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F4SVHuet2LciDwg5otuvsr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full implementation-ready design for the market data backend covering:
Incorporates all findings from the code review: version counter under lock, get_tickers() as public method, _fetch_snapshots mock strategy for test resilience without massive package installed, correct return type annotation on _generate_events.
Claude-Session: https://claude.ai/code/session_01F4SVHuet2LciDwg5otuvsr