Skip to content

fix(xr): disable post-processing while presenting #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ecto merged 1 commit into from
May 3, 2026
Merged

fix(xr): disable post-processing while presenting #174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions packages/app/src/components/ViewportContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1785,8 +1785,12 @@ export function ViewportContent({ mode = "3d" }: { mode?: "3d" | "pcb" }) {
</>
)}

{/* Post-processing effects - disabled during camera motion for FPS */}
{engineReady && !isCameraMoving && sceneSettings.postProcessing.ambientOcclusion?.enabled !== false && sceneSettings.postProcessing.vignette?.enabled !== false && (
{/* Post-processing effects - disabled during camera motion for FPS, and
while a WebXR session is active. EffectComposer renders to an
offscreen target and blits to the canvas, which doesn't write to the
XR layer's framebuffer — so in VR/AR the scene goes black and only
objects rendered directly by WebXRManager (hands, controllers) show. */}
{engineReady && !isCameraMoving && !xrPresenting && sceneSettings.postProcessing.ambientOcclusion?.enabled !== false && sceneSettings.postProcessing.vignette?.enabled !== false && (
<EffectComposer>
<N8AO
aoRadius={sceneSettings.postProcessing.ambientOcclusion?.radius ?? 0.5}
Expand All @@ -1802,7 +1806,7 @@ export function ViewportContent({ mode = "3d" }: { mode?: "3d" | "pcb" }) {
</EffectComposer>
)}
{/* AO only mode */}
{engineReady && !isCameraMoving && sceneSettings.postProcessing.ambientOcclusion?.enabled !== false && sceneSettings.postProcessing.vignette?.enabled === false && (
{engineReady && !isCameraMoving && !xrPresenting && sceneSettings.postProcessing.ambientOcclusion?.enabled !== false && sceneSettings.postProcessing.vignette?.enabled === false && (
<EffectComposer>
<N8AO
aoRadius={sceneSettings.postProcessing.ambientOcclusion?.radius ?? 0.5}
Expand All @@ -1813,7 +1817,7 @@ export function ViewportContent({ mode = "3d" }: { mode?: "3d" | "pcb" }) {
</EffectComposer>
)}
{/* Vignette only mode */}
{engineReady && !isCameraMoving && sceneSettings.postProcessing.ambientOcclusion?.enabled === false && sceneSettings.postProcessing.vignette?.enabled !== false && (
{engineReady && !isCameraMoving && !xrPresenting && sceneSettings.postProcessing.ambientOcclusion?.enabled === false && sceneSettings.postProcessing.vignette?.enabled !== false && (
<EffectComposer>
<Vignette
offset={sceneSettings.postProcessing.vignette?.offset ?? 0.3}
Expand Down