Remove Python 2 compatibility code. - #28
Merged
Merged
Conversation
cristian-codorean
force-pushed
the
drop-python2-compat
branch
from
June 10, 2026 17:57
436bb68 to
523d06d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #27, which set
requires-python = ">=3.8": remove the Python 2 compatibility code that is now dead.from __future__ import print_function.try/except ImportErrorinto plainurllib/http.clientimports.import sslguard: the module never usesssldirectly (urllib handles TLS), andsys.exit()at import time is hostile to embedding applications. Pythons built without SSL fail with a clear error on first HTTPS request anyway.Ignore303.redirect_request: usereq.data/req.origin_req_hostdirectly (theget_data()/get_origin_req_host()fallbacks were for Python < 3.4).(object)bases.No functional change intended. Verified locally: module compiles, imports, and the redirect handler preserves
data/origin_req_hoston 301/302 and returnsNoneon 303, as before.🤖 Generated with Claude Code