Allow clientId together with clientAssertion/clientAssertionType - #753
Open
jnbdz wants to merge 1 commit into
Open
Allow clientId together with clientAssertion/clientAssertionType#753jnbdz wants to merge 1 commit into
jnbdz wants to merge 1 commit into
Conversation
Some providers (e.g. Microsoft Entra, Keycloak) require the client_id to be present in the token request even when the client authenticates with an assertion. Send the assertion parameters whenever the client does not authenticate with a client secret, instead of only when no client_id is configured. Fixes eclipse-vertx#713
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some providers (e.g. Microsoft Entra, Keycloak) require the
client_idto be present in the token request even when the client authenticates with an assertion, and the OIDC core spec includesclient_idin itsprivate_key_jwtexample as well.Previously
OAuth2API.token()only sentclient_assertion/client_assertion_typewhen noclientIdwas configured. This change sends the assertion parameters whenever the client does not authenticate with a client secret, soclient_idand the assertion can be used together. Client secret authentication still takes precedence and does not send the assertion.Added
OAuth2ClientAssertionTestcovering:client_id+ assertion sent togetherFixes #713