refactor: consolidate multi-module Maven project into single module#139
Open
rpoet-jh wants to merge 4 commits into
Open
refactor: consolidate multi-module Maven project into single module#139rpoet-jh wants to merge 4 commits into
rpoet-jh wants to merge 4 commits into
Conversation
Merge all 9 sub-modules (pass-core-object-service, pass-core-doi-service, pass-core-file-service, pass-core-user-service, pass-core-policy-service, pass-core-usertoken, pass-core-test-config, pass-core-main, jacoco-aggregate-report-pass-core) into a single Maven module rooted at the repository root. - Replace parent POM (packaging=pom) with single-module POM (packaging=jar) - Consolidate all dependencies and plugins into root pom.xml - Move all Java sources into src/main/java and src/test/java - Move all resources into src/main/resources and src/test/resources - Move Dockerfile, entrypoint.sh, init_postgres.sh to repo root - Update Dockerfile COPY instruction for new JAR artifact name - Replace aggregate JaCoCo module with single-module coverage report - Update sonar.coverage.jacoco.xmlReportPaths for single-module layout - Add Shibboleth repository to root POM - Add maven-failsafe-plugin for integration test execution All 179 unit tests pass. Build produces target/pass-core-2.6.0-SNAPSHOT-exec.jar. File content integrity verified via MD5 checksums (183/183 files match).
Add maven-jar-plugin execution to produce a test-config classified jar (pass-core-2.6.0-SNAPSHOT-test-config.jar) containing the same resources as the former pass-core-test-config module: application-test.yml and saml2/ directory. Consumers should update their dependency to use classifier=test-config on the pass-core artifact.
|
markpatton
approved these changes
Apr 29, 2026
Contributor
markpatton
left a comment
There was a problem hiding this comment.
I did some local testing and it is running well. This is a nice simplification.
I also looked through the github actions and I don't see anything that should cause a problem. I think the existing release actions will just work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Merge all 9 sub-modules (pass-core-object-service, pass-core-doi-service, pass-core-file-service, pass-core-user-service, pass-core-policy-service, pass-core-usertoken, pass-core-test-config, pass-core-main, jacoco-aggregate-report-pass-core) into a single Maven module rooted at the repository root.
All 179 unit tests pass. Build produces target/pass-core-2.6.0-SNAPSHOT-exec.jar. File content integrity verified via MD5 checksums (183/183 files match).
AI Disclosure: Kiro IDE 0.11.133 with Claude Sonnet 4.6 was used in Spec Mode to make the changes in this PR. Most of the changes are just git renames. I have reviewed the POM consolidation to ensure it contains the needed elements from the multi-module POMs. I have also tested locally using pass-docker.
Important Notes:
Used Kiro to create
StorageFileTest.javato bump the test coverage for SQ. One thing to verify is this methodtestEquals_uuidNotConsideredInEquality, should uuid be included in equals?In pass-support, we will have to update the POMs to use the pass-core-test-config jar file like this: