Cleanup use of dicts, e.g. use of .keys()#5165
Open
Flamefire wants to merge 1 commit intoeasybuilders:developfrom
Open
Cleanup use of dicts, e.g. use of .keys()#5165Flamefire wants to merge 1 commit intoeasybuilders:developfrom
dicts, e.g. use of .keys()#5165Flamefire wants to merge 1 commit intoeasybuilders:developfrom
Conversation
Flamefire
force-pushed
the
cleanup-dicts
branch
2 times, most recently
from
efc69aa to
e3683a6
Compare
Using `x in dict.keys()` is discouraged and should be `x in dict` directly which is potentially more performant and easier to read/shorter. Accesses to keys and their values should use `dict.items` to avoid the lookup overhead.
Flamefire
force-pushed
the
cleanup-dicts
branch
from
e3683a6 to
f3d4804
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
x in dict.keys()is discouraged and should bex in dictdirectly which is potentially more performant and easier to read/shorter. Accesses to keys and their values should usedict.itemsto avoid the lookup overhead.