Skip to content

Add spanish carrion crows dataset#255

Open
mcusi wants to merge 3 commits into
mainfrom
add-spanish-carrion-crows
Open

Add spanish carrion crows dataset#255
mcusi wants to merge 3 commits into
mainfrom
add-spanish-carrion-crows

Conversation

@mcusi
Copy link
Copy Markdown
Contributor

@mcusi mcusi commented Mar 17, 2026

I'm adding the unsynchronized, audio-only version of the carrion crow biologger dataset. It is a detection dataset (Voxaboxen bounding boxes). I followed WABAD/ArcticBirdSounds as templates.

@mcusi mcusi requested a review from a team as a code owner March 17, 2026 04:33
Comment thread esp_data/datasets/spanish_carrion_crows.py Outdated

audio, sr = read_audio(audio_path)
# Should all be mono
# audio = audio_stereo_to_mono(audio, mono_method="average").astype(np.float32)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can just remove the line if its already mono (maybe test with an assert in your tests)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok removed and added a test. I realized that I took out the .astype(np.float32) as well when I did this. Is it important to keep float32 for any reason? (The tests check for float64 so it's consistent with itself right now)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well float32 saves memory (especially GPU).. and float64 doesn't really offer much more useful precision for audio ?

the other thing is that every dataset (I believe) in esp_data is enforcing float32 so having float64 in just this one will break experiments where this dataset is concatenated / chained with others in a training loop ... wdyt ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'll leave in the conversion to float32

Comment thread esp_data/datasets/spanish_carrion_crows.py
Comment thread esp_data/datasets/spanish_carrion_crows.py Outdated
Comment thread esp_data/datasets/spanish_carrion_crows.py Outdated
Comment thread tests/test_spanish_carrion_crows.py Outdated
Copy link
Copy Markdown
Collaborator

@GaganNarula GaganNarula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments to discuss but in principle it looks good!

@mcusi
Copy link
Copy Markdown
Contributor Author

mcusi commented Mar 18, 2026

I think I addressed all the comments so far now. Jules said it would be useful to add call types, I will do that in a second version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants