Resamplers#176
Conversation
On GPU or CPU? Also why are we doing this now? Is it a priority? |
|
sorry for intervening...since we noted difference in the results given the resampling method, this should be done cautiously, benchmarking with torch and the usual librosa method we used in the past to see if we get similar results |
|
yeah this changes the default to torchaudio so we have to careful |
|
yup you guys are right! thats why its only a draft PR. However, we should discuss this soon because for most of the datasets in esp-data on-the-fly resampling is required because a) there aren't already existing sample rate versions in the buckets (like iNaturalist) and b) resampling with librosa is about 300x slower (not a full benchmark, just taking one file 90 sec file and resampling it 100 times). |
cpu test |
3 participants
Adding torchaudio resampler. #122
It is definitely an order of magnitude faster..