refactor post_actions to be cleaner

[jduan00]

Improve the code’s readability by cleaning it up.

Summary by CodeRabbit

• Refactor
  • Optimized internal post-action processing logic for improved code clarity and maintainability.

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

postAction in post_actions.ts is reformatted and its FDX/cross-border skip logic is simplified: isCrossBorder is now derived via entity.additional?.isCrossBorder === true, the 3300/3400 status skip applies when isFdx && !isCrossBorder, the warning log message changes to "missing major status", and the loop iterates directly over getMissingCriticalStatuses().

Changes

postAction FDX/cross-border refactor

Layer / File(s)	Summary
FDX/cross-border skip logic and logging src/main/post_actions.ts	isCrossBorder is derived with optional chaining (entity.additional?.isCrossBorder === true). The 3300/3400 status exemption now triggers on isFdx && !isCrossBorder instead of checking for undefined. Warning log text changes from "missing critical status" to "missing major status". Loop eliminates the intermediate missingStatuses variable. Imports and surrounding structure are reformatted.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• eagle1-sys/whereis-api-v0#486: Introduced the post_actions module and the initial postAction implementation that this PR directly refactors.

Poem

🐇 Hop, hop, through the border gate,
Optional chaining makes logic great!
No more undefined to confuse the trail,
FDX skips work without fail.
"Major" now where "critical" once stood —
A cleaner warren, as a rabbit should! 🌿

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'refactor post_actions to be cleaner' directly aligns with the PR's stated objective of improving code readability and cleaning up the implementation in post_actions.ts.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch main

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}