fix(android): prevent keyboard overlap across input screens - #193
Open
chliny wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windowSoftInputMode="adjustPan".KeyboardAvoidingViewenabled only on iOS for the connection add/edit forms and session composer.Scope
This covers the connection add/edit forms as well as the session composer. It is an alternative to the Android inset-based composer-only approach in #190 and the broader bundled changes in #182.
Verification
npm test: 333 passed, 0 failed.npm run typecheck: passed.assembleRelease -PreactNativeArchitectures=arm64-v8apassed.Related: #156, #190, #182.