fix(install): support single-skill repos with SKILL.md at path root#1497
Open
lgaudez wants to merge 2 commits intodyoshikawa:mainfrom
Open
fix(install): support single-skill repos with SKILL.md at path root#1497lgaudez wants to merge 2 commits intodyoshikawa:mainfrom
lgaudez wants to merge 2 commits intodyoshikawa:mainfrom
Conversation
When a git source exposes a single skill at the root of skillsPath (e.g. SKILL.md at path: ""), all files have no "/" in relativePath and were silently skipped. Add a fallback that maps root-level files to the single explicit skill name when skills filter is not a wildcard. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchSourceViaGitsilently skipped all files when a remote repo exposes a single skill at the root ofskillsPath(e.g.SKILL.mddirectly at path""), because every file hasrelativePath.indexOf("/") === -1and was skipped by the existing loopskillFileMapis empty after the main loop,skillsfilter contains exactly one non-wildcard name, and root-level files exist*) is intentionally excluded from the fallback since the skill name would be ambiguousNote that I opened the PR because I tried to add this skill in mu rylesync.jsonc -> "https://github.com/blader/humanizer.git"
rulesync.jsonc sample :
Test plan
should install single-skill repo with SKILL.md at path root- verifies the happy pathshould still handle classic subdirectory skill structure- regression, existing behavior unchangedshould not install root-level files when skills filter is wildcard- wildcard stays at 0 skills