add installable package - #45
Conversation
|
@ccotter do you mind taking a look? I don't understand CMake much. |
| $<INSTALL_INTERFACE:include> | ||
| $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}> | ||
| ) | ||
| target_compile_features(relacy INTERFACE cxx_std_11) |
There was a problem hiding this comment.
does this specify an exact version, or can the library user still specify a higher version?
There was a problem hiding this comment.
It is a minimum version, see requiring language standards. (not exactly intuitive syntax, I agree).
ccotter
left a comment
ccotter
left a comment
There was a problem hiding this comment.
I typically consume libraries via pkg-config metadata, so I have less experience with the find_package(relacy...) approach, but otherwise this looks good to me. Thanks!
|
@dvyukov - confirming you're ok with me merging? If you'd like me to review and merge PRs in the future, feel free to assign me as reviewer and I'll take that as a signal for me to review/merge as I see fit, unless you comment otherwise. |
Yes, I am ok with merging this. Please try to merge, let's see if it works. |
|
Awesome, thank you all for taking time to review/merge! Happy to help with any follow-ups (though hopefully no churn!) |
3 participants
edits cmake scripts to make
relacyinstallable so thatfind_package(relacy REQUIRED)works.Test Plan
made a sample package (copied examples) and verify that relacy is found in a custom install prefix.