fix(winget): skip submission when an update PR is already open#157
Merged
Conversation
Submitting a new version while a previous one is still under review stacks up open PRs against microsoft/winget-pkgs and adds needless work for their moderators. Check for an open Codeby.RIGStats PR first and skip the run if one exists — the next release after it merges will pick up the latest version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
winget-submit.ymlfires unconditionally after every release, which can stack multiple open PRs againstmicrosoft/winget-pkgsfor the same package if releases ship faster than moderators can review them — extra manual burden on volunteer moderators (see Only allow 1 or 2 "New version" PR(s) per package to be open at a time, to reduce the PR backlog. microsoft/winget-pkgs#333536 for the backlog problem this causes at scale).wingetcreatesubmit step: if an open PR titledCodeby.RIGStatsalready exists inmicrosoft/winget-pkgs, skip the run entirely. The next release's run will pick up the latest version once the open PR merges.Test plan