fix(nfc): suppress physical tag NDEF dispatch while HCE sharing is active#2
Merged
Merged
Conversation
Copilot
AI
changed the title
feat(nfc): replace tag writing with HCE Type 4 Tag emulation
fix(nfc): suppress physical tag polling during HCE emulation
Jul 5, 2026
Copilot
AI
changed the title
fix(nfc): suppress physical tag polling during HCE emulation
fix(nfc): suppress physical tag NDEF dispatch while HCE sharing is active
Jul 5, 2026
|
✅ Debug APK artifact is ready for commit ba3f9cc . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enableReaderModewas called with onlyFLAG_READER_NO_PLATFORM_SOUNDSand no technology flags. Without at least oneFLAG_READER_NFC_*flag, the NFC stack never enters reader mode for any technology — tag discoveries still flow through normal OS NDEF dispatch, causing URLs on physical Mifare/NDEF tags to open while sharing is active.Fix
Add all four technology flags plus
FLAG_READER_SKIP_NDEF_CHECKto theenableReaderModecall:adapter?.enableReaderMode( activity, { /* physical tag discovered during sharing – intentionally ignored */ }, NfcAdapter.FLAG_READER_NFC_A or NfcAdapter.FLAG_READER_NFC_B or NfcAdapter.FLAG_READER_NFC_F or NfcAdapter.FLAG_READER_NFC_V or NfcAdapter.FLAG_READER_SKIP_NDEF_CHECK or NfcAdapter.FLAG_READER_NO_PLATFORM_SOUNDS, null, )With all tech flags set, any physical tag (Mifare, NTAG2xx, ISO-DEP, FeliCa, ISO 15693) discovered during sharing is routed to the no-op callback —
NDEF_DISCOVERED/TAG_DISCOVEREDintents are never dispatched.FLAG_READER_SKIP_NDEF_CHECKavoids the unnecessary NDEF compatibility check on tags we discard anyway. HCE card emulation is unaffected; it runs on an independent path in the NFC controller.