Pushy gf - #64
Conversation
Merge request for the gf plz
dual-wield-ray
left a comment
dual-wield-ray
left a comment
There was a problem hiding this comment.
All the .idea/* files seem to be files generated by IntelliJ, so should be ignored by source control.
Something like this in the project's .gitignore:
.idea/*
dual-wield-ray
left a comment
dual-wield-ray
left a comment
There was a problem hiding this comment.
Ok review complete! Good work. 🙂
When changes are done you will also see that there are unit tests that need to be green before merging. We can look into running them in your IDE together if you want (sorry I should have mentioned them earlier).
| with open(save_path, "wb") as f: | ||
| f.write(xml_str) | ||
|
|
||
| zip_file= zipfile.ZipFile("pydrumscore/_exported/" + metadata.workTitle + ".mscz", "w") |
There was a problem hiding this comment.
Doing this means that every time we run the export, we will export both in .mscx and .mscz. Instead I think we should have the choice by giving an argument.
By default, the "true" export format for MuseScore is the zipped one. So we should by default export in .mscz, but accept an argument that exports with the old method instead, unzipped. Could be a flag like -u for "uncompressed", which would be used for unit tests and during development :)
|
|
||
| # locate the tag you want to modify | ||
| for elem in myroot.iter(): | ||
| if elem.tag == "rootfile" and "full-path" in elem.attrib: |
There was a problem hiding this comment.
I see in container.xml that there are many tags with rootfile and full-path. So if we rely on an existing tag to change, it will be dependent on the order.
Instead can we just create it on the fly?
| @@ -0,0 +1,9 @@ | |||
| <container> | |||
| <rootfiles> | |||
| <rootfile full-path="King Nothing.mscx" /> | |||
There was a problem hiding this comment.
See my other comment, this line would be removed and instead be created on the spot.
2 participants
No description provided.