Draft
Resolve CodeQL ineffectual-statement findings in protocol method stubs#1638
Conversation
Copilot
AI
changed the title
[WIP] Fix code quality findings #7, #6, #5
Resolve CodeQL ineffectual-statement findings in protocol method stubs
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the three requested code-quality findings (#5, #6, #7) by removing ineffectual expression statements in protocol method bodies. The update is limited to the flagged locations and preserves typing/protocol intent.
Scope
bowtie/_commands.pybowtie/_core.pyChanges
...expression statements in protocol method bodies withpass:Command.to_request(...)Command.from_response(...)_MakeValidator.__call__(...)Why this resolves the findings
...as a bare expression is reported aspy/ineffectual-statement;passprovides an explicit no-op body for protocol stubs without changing interface contracts.