ci: verify the actual Vercel build path on every PR - #473
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verify Vercel BuildCI job that runsscripts/build-vercel.shon every PR, the literal command Vercel executes for every production deploymentapi/v1/*imports (@meridian/shared,@meridian/stellar-sdk-helpers,@meridian/api-core) doesn't have a bundleddist/index.jsafter the script runsNothing in CI previously exercised the real deploy path end to end. This already caused a production incident:
packages/api-corewas wired into everyapi/v1/*handler but never added tobuild-vercel.sh's esbuild step, so every function importing it threwERR_MODULE_NOT_FOUNDin production (fixed in #398). Nothing in CI would have caught that before it shipped.Test plan
pnpm exec bash scripts/build-vercel.shlocally against currentmain: succeeds, all threedist/index.jsfiles producedapi-coreesbuild step frombuild-vercel.sh, re-ran the script, confirmed the assertion step correctly reportspackages/api-core/dist/index.js was not produced, then restored the script (verified zero diff against the original)pnpm lint && pnpm typecheckpass locallyCloses #401