Skip to content

ci: verify the actual Vercel build path on every PR - #473

Merged
collinsezedike merged 1 commit into
mainfrom
ci/verify-vercel-build
Aug 4, 2026
Merged

ci: verify the actual Vercel build path on every PR#473
collinsezedike merged 1 commit into
mainfrom
ci/verify-vercel-build

Conversation

@collinsezedike

Copy link
Copy Markdown
Collaborator

Summary

  • Adds a Verify Vercel Build CI job that runs scripts/build-vercel.sh on every PR, the literal command Vercel executes for every production deployment
  • Adds an assertion step that fails the check if any workspace package api/v1/* imports (@meridian/shared, @meridian/stellar-sdk-helpers, @meridian/api-core) doesn't have a bundled dist/index.js after the script runs

Nothing in CI previously exercised the real deploy path end to end. This already caused a production incident: packages/api-core was wired into every api/v1/* handler but never added to build-vercel.sh's esbuild step, so every function importing it threw ERR_MODULE_NOT_FOUND in production (fixed in #398). Nothing in CI would have caught that before it shipped.

Test plan

  • Ran pnpm exec bash scripts/build-vercel.sh locally against current main: succeeds, all three dist/index.js files produced
  • Reproduced the exact fix(build): bundle api-core for the Vercel serverless runtime #398 regression locally: removed the api-core esbuild step from build-vercel.sh, re-ran the script, confirmed the assertion step correctly reports packages/api-core/dist/index.js was not produced, then restored the script (verified zero diff against the original)
  • pnpm lint && pnpm typecheck pass locally

Closes #401

@vercel

vercel Bot commented Aug 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
meridian Ready Ready Preview Aug 4, 2026 11:20pm

@collinsezedike
collinsezedike merged commit b7d39b4 into main Aug 4, 2026
10 checks passed
@collinsezedike
collinsezedike deleted the ci/verify-vercel-build branch August 4, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Chore] CI never builds or verifies the actual Vercel deploy path

1 participant