Fixed an issue from PR #93#100
Conversation
…at_get_github_username_by_doid(), implemented GH username parsing
|
This pull request should be merged after my one in order not to break added features after merge conflicts fixes. |
|
@BR0kEN- Please, remove functions that are connected with github now. Now, all github stuff is postponed for better concentration on d.org analysis. |
|
@anpolimus, nothing connects to GH. |
|
@BR0kEN- |
| <li>'.t('Active commenters').' : <strong>' . $active_by_comments_count . ' (' . number_format($active_by_comments_count/$all_user_count, 2)*100 . ')%</strong></li> | ||
| </ul> | ||
| </div>'; | ||
| if ($all_user_count > 0) { |
There was a problem hiding this comment.
Prevented division by zero (when no users in DB).
|
Don't know what else I can describe. Suppose that code is understandable but, if not, you can ask me. :) |
|
Thx. Let me review that |
| $variables, | ||
| $page | ||
| ); | ||
| $r = _ppgetstat_api_call('api-d7/user.json', $variables, $page); |
There was a problem hiding this comment.
Please, dont delete first parameter from _ppgetstat_api_call function.
In addition to the drupal.org we also have association api at the another domain
Also we will work to get localize.drupal.org api live and scan them too.
|
@BR0kEN- Please, make your pull request sync with master. |
Build comment file:Build site installed at http://ci-ukr.sanchiz.net/build-ppdorg-9 Test PASSed. |
|
@Sanchiz, give me credentials to login to builds please. |
| // Remove expired cached pages. | ||
| _ppgetstat_cron_remove_cached_pages(); | ||
|
|
||
| //Start users sync process with d.org |
There was a problem hiding this comment.
@anpolimus, what you can suggest according to removal of these lines? I don't want reinstall the site and wait until history for 12 years will be obtained. This should be run only on production.
|
?? |
3 participants
#93 (comment)