Skip to content

AtomicCounter refactor #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msizov merged 14 commits into from
Jul 10, 2026
Merged

AtomicCounter refactor #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c4dbd28
Add TLA+ spec of the sync protocol; fix the bugs it surfaced
Termina1 Jul 5, 2026
c010b7e
Add regression tests for the sync protocol bugs
Termina1 Jul 5, 2026
c358310
Add TLA witness for cho.last allocator race
Termina1 Jul 6, 2026
c8b947d
Fix the cho.last allocator race shown by the TLA+ witness
Termina1 Jul 6, 2026
daa3cce
throttle atomic counters via separate manager
msizov Jun 23, 2026
bf5d9e0
add commitbatch method
msizov Jun 24, 2026
439fc90
batch drain together, CommitBatch uses drain
msizov Jun 29, 2026
9896022
don't cache unloaded counters
msizov Jul 1, 2026
01d05ab
make atomic counters track their deltas
msizov Jul 8, 2026
9a3c969
recompute chotki index on objects changes (from batch or from counters)
msizov Jul 8, 2026
2d338e4
merge with TLA branch, add TLA for batch path
msizov Jul 8, 2026
67f4900
fix reindex, add methods for atomic sequential writes
msizov Jul 8, 2026
646588f
rework index manager
msizov Jul 10, 2026
d72d952
fix metrics leak
msizov Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,15 @@ ragel:
lint:
golangci-lint run ./...

# Model-check the replication protocol spec (needs tla2tools.jar, see tla/README.md)
TLA2TOOLS ?= tla2tools.jar
.PHONY: tla
tla:
cd tla && for cfg in MCFixed MCFixedChurn MCFixedLast MCWitness MCPing MCBatchFixed MCBatchFixedLast; do \
echo "=== $$cfg ==="; \
java -XX:+UseParallelGC -cp $(TLA2TOOLS) tlc2.TLC -config $$cfg.cfg -workers auto -deadlock MCChotkiSync || true; \
done

.PHONY: update-pebble
update-pebble:
go mod edit -replace github.com/cockroachdb/pebble=github.com/drpcorg/pebble@master
Expand Down
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,10 @@ Internally, Chotki is [pebble db][p] using [RDX](./rdx) merge operators.
See the RDX doc for further details on its serialization format
(type-length-value) and a very predictable choice of CRDTs.

The replication protocol is described in [replication](./replication)
and has a formal TLA+ specification in [tla](./tla), model-checked with
TLC (including reproductions of historical protocol bugs).

## Comparison to other projects

Overall, RDX is the final version of RON (Replicated Object
Expand Down
Loading
Loading