Skip to content

Keep generated outputs under output root#360

Merged
KevinRK29 merged 1 commit intodropbox:codex/asky/stone-output-manifestfrom
aaronsky:codex/asky/stone-output-root-validation
May 6, 2026
Merged

Keep generated outputs under output root#360
KevinRK29 merged 1 commit intodropbox:codex/asky/stone-output-manifestfrom
aaronsky:codex/asky/stone-output-root-validation

Conversation

@aaronsky
Copy link
Copy Markdown
Contributor

@aaronsky aaronsky commented May 6, 2026

Description

Stacked on #359.

Makes Stone reject backend writes that resolve outside the configured output root.

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • Code Change
  • Example/Test Code Change

Validation

  • Have you ran tox?
  • Do the tests pass?

Verification run directly with the CI lint/test steps:

  • uv run --no-project --with-requirements requirements.txt --with-requirements test/requirements.txt --with flake8==5.0.4 --with pylint flake8 setup.py example stone test
  • uv run --no-project --with-requirements requirements.txt --with-requirements test/requirements.txt --with flake8==5.0.4 --with pylint --with setuptools pylint --rcfile=.pylintrc setup.py example stone test
  • uv run --no-project --with-requirements requirements.txt --with-requirements test/requirements.txt --with pytest --with mock pytest
  • uv run --no-project --with-requirements requirements.txt --with-requirements test/requirements.txt --with enum34 --with mypy --with types-six ./mypy-run.sh

@aaronsky aaronsky force-pushed the codex/asky/stone-output-root-validation branch from 69f3959 to 55f2793 Compare May 6, 2026 13:48
@aaronsky aaronsky force-pushed the codex/asky/stone-output-manifest branch from 74149bf to 4957fbe Compare May 6, 2026 13:48
@aaronsky aaronsky force-pushed the codex/asky/stone-output-root-validation branch from 55f2793 to c96192c Compare May 6, 2026 14:00
@aaronsky aaronsky force-pushed the codex/asky/stone-output-manifest branch from 4957fbe to a42376c Compare May 6, 2026 14:00
@KevinRK29 KevinRK29 merged commit 62d7da2 into dropbox:codex/asky/stone-output-manifest May 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants