feat(links): open external links in a new tab#52
Merged
Conversation
Every anchor that points off-site now opens in a new tab with rel="noopener noreferrer" (security: a new-tab link must not hand the opened page window.opener access). Internal links — relative, #anchors, and absolute toolspace.yepgent.com URLs — are left in the same tab. Implementation is a single idempotent helper, scripts/_external_links.py (mark_external_links), hooked into both page generators (build_registry_pages, build_changelog_page) and run once over the three hand-authored static pages (index, publish, case-study/muninn). "External" = an absolute http(s) URL whose host is not toolspace.yepgent.com. Idempotent: anchors that already declare target= are skipped and rel is merged order-independently, so it is safe to re-run every build. Registry pages were regenerated with timestamps pinned to the committed values, so the diff is the target/rel change only — no "Pages generated" churn. build_registry_pages.py --check and build_changelog_page.py --check both pass; full pytest suite green (36 passed). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every anchor that points off-site now opens in a new tab with
rel="noopener noreferrer"(security: a new-tab link must not give the opened pagewindow.openeraccess). Internal links — relative,#anchors, and absolutetoolspace.yepgent.comURLs — stay in the same tab.Implementation: one idempotent helper,
scripts/_external_links.py(mark_external_links), hooked into both page generators (build_registry_pages,build_changelog_page) and run once over the three hand-authored static pages (index,publish/,case-study/muninn/). "External" = an absolute http(s) URL whose host is nottoolspace.yepgent.com.target=are skipped;relis merged order-independently. Safe to re-run every build.build_registry_pages.py --check+build_changelog_page.py --checkpass; full pytest suite green (36 passed).🤖 Generated with Claude Code