fix(ci): skip Playwright report publish when S3 is unset - #11
Merged
Conversation
The publish workflow was failing on main because S3 credentials are not configured. Visual report upload is optional; skip it instead of failing the commit status, and keep failing when credentials exist but the destination variables are incomplete. Co-authored-by: Gaffer <drferdiiskandar@sentrahai.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI on
main(8cb8099) is green for product jobs (ci,publish-server-image). The red check ispublishfrompublish Playwright report.That workflow uploads the Playwright screenshot gallery to S3. It currently fails hard when
S3_ACCESS_KEY_ID/S3_SECRET_ACCESS_KEYare empty:This is optional ops infrastructure, not a product regression. Nightly
publish_report: truewould hit the same failure.Change
S3_BUCKET, etc.) are incomplete.workflow_runjob when credentials are missing.Test
pnpm exec vitest run packages/testkit/src/publish-playwright-report.test.ts2 passed.
After merge, the next
cicompletion onmainwill run this workflow from default-branch code and skip instead of failing. Historical status on8cb8099stays failed.To actually publish galleries later, set
S3_ACCESS_KEY_ID,S3_SECRET_ACCESS_KEY,S3_BUCKET,S3_ENDPOINT, andPLAYWRIGHT_PUBLIC_BASE_URL.