Fix CI: resolve pre-commit lint, compilation, and environment failures#132
Open
lriggs wants to merge 2 commits intodremio:dremio_27.0_20from
Open
Fix CI: resolve pre-commit lint, compilation, and environment failures#132lriggs wants to merge 2 commits intodremio:dremio_27.0_20from
lriggs wants to merge 2 commits intodremio:dremio_27.0_20from
Conversation
- Apply clang-format to all Gandiva encrypt_utils and related C++ files - Apply cmake-format to vcpkg portfiles (brotli, llvm, symengine) - Fix cpplint runtime/int: add NOLINT for OpenSSL-required unsigned long - Fix engine.cc: pass DataLayout directly to setDataLayout() to be compatible with both LLVM 14 (llvm::Optional) and LLVM 21 (std::optional) - Fix benchmark_util.h: replace deprecated benchmark::internal::Benchmark with benchmark::Benchmark (newer Google Benchmark API) - Fix install_gcs_testbench.sh: install setuptools before pipx to provide pkg_resources needed by grpcio wheel build in conda builds - Fix msys2_setup.sh: add llvm package so Gandiva can find LLVMAlt in Windows MinGW (MINGW64/CLANG64) build environments Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Fix benchmark_util.h: use #pragma to suppress -Wdeprecated-declarations
around benchmark::internal::Benchmark usage, restoring MSVC compatibility
(benchmark::Benchmark doesn't exist in older Google Benchmark on Windows)
- Fix install_gcs_testbench.sh: use --prefer-binary pip flag so grpcio
installs from a pre-built wheel, avoiding the pkg_resources build failure
in isolated pip environments (Python 3.12+ no longer auto-includes setuptools)
- Fix ree_util.h: remove \par Doxygen tags that triggered -Werror,-Wdocumentation
on macOS Clang ("empty paragraph passed to \par command")
- Fix rat_exclude_files.txt: add ci/vcpkg/overlay/** so Apache RAT does not
flag vcpkg portfiles and usage files that lack ASF license headers
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes multiple pre-existing CI failures in the
dremio_27.0_20branch that were causing nearly all checks to fail on any PR.clang-formatto all Gandivaencrypt_utils*and related files; applycmake-formatto vcpkg portfiles (brotli, llvm, symengine); addNOLINT(runtime/int)forunsigned longrequired by OpenSSL APIengine.cc- passDataLayoutdirectly tosetDataLayout()instead ofstd::make_optional(data_layout), which is incompatible with LLVM 14'sllvm::Optionaltypebenchmark_util.h- replace deprecatedbenchmark::internal::Benchmarkwithbenchmark::Benchmark(newer Google Benchmark API; flagged as-Werror)install_gcs_testbench.sh- installsetuptoolsbeforepipxto providepkg_resourcesrequired bygrpciowheel buildmsys2_setup.sh- addllvmpackage so Gandiva can findLLVMAltin MINGW64/CLANG64 environmentsTest plan
🤖 Generated with Claude Code