docs(gandiva): add design doc for micro/nanosecond timestamp support#130
Draft
timhurskidremio wants to merge 2 commits intodremio:dremiofrom
Draft
docs(gandiva): add design doc for micro/nanosecond timestamp support#130timhurskidremio wants to merge 2 commits intodremio:dremiofrom
timhurskidremio wants to merge 2 commits intodremio:dremiofrom
Conversation
Covers the full function set (extract, date_trunc, cast, arithmetic) for Timestamp(MICRO) and Timestamp(NANO), including implementation approach, valid range constraints, overflow behavior, and test strategy. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…icro/nano timestamps Recovered from dismissed session. Adds EpochTimePoint conversion problem analysis (chose delegation wrappers over macro modification or templatization), scopes out timestamp arithmetic, and breaks implementation into 4 phases: infrastructure, extract functions, date_trunc, and cast functions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers the full function set (extract, date_trunc, cast, arithmetic) for Timestamp(MICRO) and Timestamp(NANO), including implementation approach, valid range constraints, overflow behavior, and test strategy.
This PR is not intended for merging, only for reviewing with a subsequent publishing in Apache Arrow issues as a proposal