Skip to content

Stop reporting external feed-source errors to Honeybadger#644

Merged
dreikanter merged 2 commits into
masterfrom
stop-reporting-feed-source-errors
May 24, 2026
Merged

Stop reporting external feed-source errors to Honeybadger#644
dreikanter merged 2 commits into
masterfrom
stop-reporting-feed-source-errors

Conversation

@dreikanter

Copy link
Copy Markdown
Owner

Summary

  • External feed-source failures (broken TLS, network errors, non-2xx responses) were being reported to Honeybadger on every pull, even though they are not code bugs and are already tracked locally in the errors table and per-feed counters. One dead source (commitstrip, failing its TLS handshake) generated 125 notices in 11 days — pure recurring noise that buries real bugs.
  • Added a notify: option to ErrorDumper (default true). When false, it skips Honeybadger.notify but still persists the Error record, so local visibility is unchanged.
  • ProcessFeed now classifies HTTP::Error, OpenSSL::SSL::SSLError, and HttpLoader::Error as source errors and dumps them with notify: false. Genuinely unexpected errors (parser bugs, NoMethodError, etc.) still report to Honeybadger.
  • Added OpenSSL::SSL::SSLError to HttpClient retryable errors so a transient handshake blip gets one retry, like timeouts and connection errors.

Checklist

  • Updated CHANGELOG.md under Unreleased, or change is internal-only

@dreikanter
dreikanter force-pushed the stop-reporting-feed-source-errors branch 2 times, most recently from ec5e107 to d0fb885 Compare May 24, 2026 13:32
@dreikanter
dreikanter force-pushed the stop-reporting-feed-source-errors branch from d0fb885 to ff75610 Compare May 24, 2026 13:33
@dreikanter
dreikanter merged commit b8935f1 into master May 24, 2026
6 checks passed
@dreikanter
dreikanter deleted the stop-reporting-feed-source-errors branch May 24, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant