Stop reporting external feed-source errors to Honeybadger#644
Merged
Conversation
dreikanter
force-pushed
the
stop-reporting-feed-source-errors
branch
2 times, most recently
from
May 24, 2026 13:32
ec5e107 to
d0fb885
Compare
dreikanter
force-pushed
the
stop-reporting-feed-source-errors
branch
from
May 24, 2026 13:33
d0fb885 to
ff75610
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
errorstable and per-feed counters. One dead source (commitstrip, failing its TLS handshake) generated 125 notices in 11 days — pure recurring noise that buries real bugs.notify:option toErrorDumper(defaulttrue). Whenfalse, it skipsHoneybadger.notifybut still persists theErrorrecord, so local visibility is unchanged.ProcessFeednow classifiesHTTP::Error,OpenSSL::SSL::SSLError, andHttpLoader::Erroras source errors and dumps them withnotify: false. Genuinely unexpected errors (parser bugs,NoMethodError, etc.) still report to Honeybadger.OpenSSL::SSL::SSLErrortoHttpClientretryable errors so a transient handshake blip gets one retry, like timeouts and connection errors.Checklist
CHANGELOG.mdunderUnreleased, or change is internal-only