Skip to content

Stop reporting errors when no service instance is available#643

Merged
dreikanter merged 1 commit into
masterfrom
stop-reporting-empty-libreddit-pool
May 24, 2026
Merged

Stop reporting errors when no service instance is available#643
dreikanter merged 1 commit into
masterfrom
stop-reporting-empty-libreddit-pool

Conversation

@dreikanter

Copy link
Copy Markdown
Owner

Summary

  • Reddit post-score fetching relies on a Libreddit instance pool that has decayed to effectively a single instance. Whenever that instance flaps (downtime or rate-limiting trips the error/suspend threshold), the pool has zero operational instances and ServiceInstance.pick! raises, flooding Honeybadger (fault #130263597, 5,243 notices) for what is an expected, recurring condition.
  • ServiceInstance.pick! now raises a dedicated ServiceInstance::NoInstanceAvailableError instead of a bare RuntimeError, so callers can tell an empty pool apart from a genuine fetch failure.
  • RedditProcessor#score rescues NoInstanceAvailableError and silently returns 0. Real fetch errors (HTTP failures etc.) are still reported via Honeybadger.notify.

Checklist

  • Updated CHANGELOG.md under Unreleased, or change is internal-only

@dreikanter
dreikanter merged commit 709dc38 into master May 24, 2026
6 checks passed
@dreikanter
dreikanter deleted the stop-reporting-empty-libreddit-pool branch May 24, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant