Skip to content

Render stat rows in semantic description lists#1094

Draft
dreikanter wants to merge 1 commit into
mainfrom
agent/f008-fix-list-semantics
Draft

Render stat rows in semantic description lists#1094
dreikanter wants to merge 1 commit into
mainfrom
agent/f008-fix-list-semantics

Conversation

@dreikanter

Copy link
Copy Markdown
Owner

Changes:

  • Make ListComponent render a <dl> when every item is a StatItemComponent.
  • Keep ordinary list-item collections rendered as <ul>.

Why:

Detail components currently place <dt>/<dd> rows inside a <ul>, which is invalid HTML. The shared container can infer the correct semantic element without changing each credential/detail component separately.

References:

Checks:

  • The change is limited to the container-tag selection.
  • GitHub Actions will verify existing component coverage.

@codecov

codecov Bot commented Jul 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.55%. Comparing base (ae0c23b) to head (a744357).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1094   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files         355      355           
  Lines        8347     8347           
=======================================
  Hits         8143     8143           
  Misses        204      204           
Files with missing lines Coverage Δ
app/components/list_component.rb 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant