Skip to content

Warn when deleting search credentials#1086

Merged
dreikanter merged 1 commit into
mainfrom
agent/f068-warn-search-credential-delete
Jul 18, 2026
Merged

Warn when deleting search credentials#1086
dreikanter merged 1 commit into
mainfrom
agent/f068-warn-search-credential-delete

Conversation

@dreikanter

Copy link
Copy Markdown
Owner

Changes:

  • Expand the search-credential deletion confirmation to warn that dependent feeds will be disabled.

Why:

The confirmation now matches the actual destructive effect and the equivalent AI-credential warning.

References:

Checks:

  • Only confirmation copy changes.
  • GitHub Actions will verify the branch.

@codecov

codecov Bot commented Jul 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.55%. Comparing base (ce0547a) to head (ce4fbd1).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1086   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files         355      355           
  Lines        8358     8358           
=======================================
  Hits         8154     8154           
  Misses        204      204           
Files with missing lines Coverage Δ
...omponents/search_credential_list_item_component.rb 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dreikanter
dreikanter marked this pull request as ready for review July 18, 2026 21:53
@dreikanter
dreikanter merged commit e842922 into main Jul 18, 2026
14 checks passed
@dreikanter
dreikanter deleted the agent/f068-warn-search-credential-delete branch July 18, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant